From 9daa842b5fa8966e4003a29c740ec94340021d17 Mon Sep 17 00:00:00 2001
From: wm4 <wm4@nowhere>
Date: Thu, 1 Mar 2018 13:41:27 +0100
Subject: player: add warning comment about ignoring ABI safety

At least ffmpeg_garbage() uses sizeof(AVFrameSideData), which is not
included in the ABI, but there's no ABI-safe alternative either.
---
 player/main.c | 3 +++
 1 file changed, 3 insertions(+)

(limited to 'player')

diff --git a/player/main.c b/player/main.c
index 243eae605f..5a3fe4c1b7 100644
--- a/player/main.c
+++ b/player/main.c
@@ -426,6 +426,9 @@ int mp_initialize(struct MPContext *mpctx, char **options)
     if (!print_libav_versions(mp_null_log, 0)) {
         // Using mismatched libraries can be legitimate, but even then it's
         // a bad idea. We don't acknowledge its usefulness and stability.
+        // Distro maintainers who patch this out should be aware that mpv
+        // intentionally ignores ABI in some places where it's not possible to
+        // get by without violating it.
         print_libav_versions(mpctx->log, MSGL_FATAL);
         MP_FATAL(mpctx, "\nmpv was compiled against a different version of "
                  "FFmpeg/Libav than the shared\nlibrary it is linked against. "
-- 
cgit v1.2.3