From 8d3259a3919aefd116941b9c5902340b52010f61 Mon Sep 17 00:00:00 2001 From: wm4 Date: Tue, 13 Jan 2015 19:32:53 +0100 Subject: client API: fix log buffer overflow case It just crashed. The prefix and text fields point to static strings in this case. Oops. Fixes the issue mentioned in #838. --- player/client.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'player') diff --git a/player/client.c b/player/client.c index eaead01006..7e9d9b5247 100644 --- a/player/client.c +++ b/player/client.c @@ -691,13 +691,13 @@ mpv_event *mpv_wait_event(mpv_handle *ctx, double timeout) event->event_id = MPV_EVENT_LOG_MESSAGE; struct mpv_event_log_message *cmsg = talloc_ptrtype(event, cmsg); *cmsg = (struct mpv_event_log_message){ - .prefix = talloc_steal(event, msg->prefix), + .prefix = msg->prefix, .level = mp_log_levels[msg->level], .log_level = mp_mpv_log_levels[msg->level], - .text = talloc_steal(event, msg->text), + .text = msg->text, }; + talloc_steal(event, msg); event->data = cmsg; - talloc_free(msg); break; } } -- cgit v1.2.3