From 0ff93a83571ede54af87ebd1aed5736f428c48d4 Mon Sep 17 00:00:00 2001 From: wm4 Date: Tue, 28 Apr 2015 22:03:18 +0200 Subject: player: clamp display time to known time range on seeking During seeking, and there is momemtarily no new data available yet, the player will display the seek target as current time. Clamp this time to the known time range as implied by the start time and the duration of the file. This improves behavior especially when seeking in audio files, for which this for some reason triggers rather often. There were some users complaining about this. This makes behavior worse for files with timestamp resets, or incorrectly reported duration. (The latter is relatively common, e.g. libavformat shortcomings, or incomplete files.) --- player/playloop.c | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'player') diff --git a/player/playloop.c b/player/playloop.c index c34ae7e6da..0c0de44997 100644 --- a/player/playloop.c +++ b/player/playloop.c @@ -382,6 +382,13 @@ double get_playback_time(struct MPContext *mpctx) { double cur = get_current_time(mpctx); double start = get_start_time(mpctx); + // During seeking, the time corresponds to the last seek time - apply some + // cosmetics to it. + if (mpctx->playback_pts == MP_NOPTS_VALUE) { + double length = get_time_length(mpctx); + if (length >= 0) + cur = MPCLAMP(cur, start, start + length); + } return cur >= start ? cur - start : cur; } -- cgit v1.2.3