From 11423acf3048445620bf1e8987b3f7aa04887cf0 Mon Sep 17 00:00:00 2001 From: rcombs Date: Wed, 23 Dec 2020 00:40:32 -0600 Subject: sub: by default, don't render timestamps after video EOF This fixes a long-standing apparent issue where mpv would display the last frame with no subtitles at EOF. This is caused by sub rendering switching from video timestamps to audio timestamps when the video ends, and audio streams often running past the timestamp of the last video frame. However, authoring tools (most notably Aegisub) don't tend to provide easy ways to add meaningful subtitles after the end of the video, so this is rarely actually useful. --- player/sub.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'player/sub.c') diff --git a/player/sub.c b/player/sub.c index ae2a85ac1c..49bae790de 100644 --- a/player/sub.c +++ b/player/sub.c @@ -114,7 +114,8 @@ static bool update_subtitle(struct MPContext *mpctx, double video_pts, // Handle displaying subtitles on VO with no video being played. This is // quite different, because normally subtitles are redrawn on new video // frames, using the video frames' timestamps. - if (mpctx->video_out && mpctx->video_status == STATUS_EOF) { + if (mpctx->video_out && mpctx->video_status == STATUS_EOF && + mpctx->opts->subs_rend->sub_past_video_end) { if (osd_get_force_video_pts(mpctx->osd) != video_pts) { osd_set_force_video_pts(mpctx->osd, video_pts); osd_query_and_reset_want_redraw(mpctx->osd); -- cgit v1.2.3