From 557e9d95317baf54e035e4fabfd45b15e6d6e708 Mon Sep 17 00:00:00 2001 From: "Avi Halachmi (:avih)" Date: Wed, 5 Aug 2020 14:57:23 +0300 Subject: win32: scripting utils.get_env_list(): use UTF-8 lua/js utils.get_env_list() uses `environ' which was ANSI, thus it broke any unicode names/values. mpv already has an internal utf8_environ for win32, but it's used only at the getenv(..) wrapper and not exposed in itself, and also it has lazy initialization - on first getenv() call. Now `environ' maps to a function which ensures initialization while keeping it an l-value (like posix expects). The cost of this fuglyness is that files should include osdep/io.h (which now declares environ as extern) rather than declaring it themselves, or else the build will break on mingw. --- player/javascript.c | 2 -- 1 file changed, 2 deletions(-) (limited to 'player/javascript.c') diff --git a/player/javascript.c b/player/javascript.c index e37fcd6c86..be28ef9e66 100644 --- a/player/javascript.c +++ b/player/javascript.c @@ -47,8 +47,6 @@ #include "client.h" #include "libmpv/client.h" -extern char **environ; - // List of builtin modules and their contents as strings. // All these are generated from player/javascript/*.js static const char *const builtin_files[][3] = { -- cgit v1.2.3