From 50991fac81eb56bc0985af2c9d31cd503302dcfe Mon Sep 17 00:00:00 2001 From: wm4 Date: Fri, 3 Feb 2017 11:32:16 +0100 Subject: sub: remove .txt as text subtitle extension If used with fuzzy matching, the player tends to pick up random text files, sometimes with interesting results. The most interesting interaction is when the user uses --log-file=something.txt, and mpv tries to open its own log file. It essentially "freezes" during probing, because every time it reads from it, it will write some more data, which in turn will cause more data to be read - until the 2MB max. probing size is slowly reached. This is not even an obscure corner case, but happened to multiple users. The .txt extension has been considered a subtitle extension ever since the code was added to MPlayer's subreader.c, but I'm not seeing many actual subtitle files with this extension, so just get rid of it. --- player/external_files.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'player/external_files.c') diff --git a/player/external_files.c b/player/external_files.c index fa0d6c0336..5eb3a1d730 100644 --- a/player/external_files.c +++ b/player/external_files.c @@ -16,7 +16,7 @@ #include "external_files.h" static const char *const sub_exts[] = {"utf", "utf8", "utf-8", "idx", "sub", "srt", - "smi", "rt", "txt", "ssa", "aqt", "jss", + "smi", "rt", "ssa", "aqt", "jss", "js", "ass", "mks", "vtt", "sup", "scc", NULL}; -- cgit v1.2.3