From 6f6c4a57ec11dc75828d3eaa8422936e912e9bb5 Mon Sep 17 00:00:00 2001 From: wm4 Date: Fri, 23 Sep 2016 15:21:59 +0200 Subject: command: fix potential UB Pointed out by quilloss on github. --- player/command.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'player/command.c') diff --git a/player/command.c b/player/command.c index 5983059448..afc556e3eb 100644 --- a/player/command.c +++ b/player/command.c @@ -290,11 +290,6 @@ int mp_on_set_option(void *ctx, struct m_config_option *co, void *data, int flag NULL }; - for (int n = 0; no_property[n]; n++) { - if (strcmp(co->name, no_property[n]) == 0) - goto direct_option; - } - // Normalize "vf*" to "vf" const char *name = co->name; bstr bname = bstr0(name); @@ -304,6 +299,11 @@ int mp_on_set_option(void *ctx, struct m_config_option *co, void *data, int flag name = tmp; } + for (int n = 0; no_property[n]; n++) { + if (strcmp(co->name, no_property[n]) == 0) + goto direct_option; + } + struct m_option type = {0}; int r = mp_property_do_silent(name, M_PROPERTY_GET_TYPE, &type, mpctx); -- cgit v1.2.3