From 5a5a3c53f75a093b1a0642174cdbd5a9504e083f Mon Sep 17 00:00:00 2001 From: wm4 Date: Sun, 1 Jun 2014 03:41:46 +0200 Subject: client API: report success status when running commands Until now, an error was reported only if the command couldn't be parsed. Attempt to do more fine-grained reporting. This is not necessarily perfect, but it's an improvement. --- player/client.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'player/client.c') diff --git a/player/client.c b/player/client.c index 0a71e5020d..ba3705a9af 100644 --- a/player/client.c +++ b/player/client.c @@ -717,8 +717,8 @@ struct cmd_request { static void cmd_fn(void *data) { struct cmd_request *req = data; - run_command(req->mpctx, req->cmd); - req->status = 0; + int r = run_command(req->mpctx, req->cmd); + req->status = r >= 0 ? 0 : MPV_ERROR_COMMAND; talloc_free(req->cmd); if (req->reply_ctx) { status_reply(req->reply_ctx, MPV_EVENT_COMMAND_REPLY, @@ -1305,6 +1305,7 @@ static const char *err_table[] = { [-MPV_ERROR_PROPERTY_FORMAT] = "unsupported format for accessing property", [-MPV_ERROR_PROPERTY_UNAVAILABLE] = "property unavailable", [-MPV_ERROR_PROPERTY_ERROR] = "error accessing property", + [-MPV_ERROR_COMMAND] = "error running command", }; const char *mpv_error_string(int error) -- cgit v1.2.3