From b3758db128fd732358a45a4719e01558a0f4bf1b Mon Sep 17 00:00:00 2001 From: wm4 Date: Sat, 22 Aug 2020 20:25:20 +0200 Subject: options: do not accept ":" as separator anymore in key/value lists Accepting ":" in addition to "," seems confusing and dumb. It only causing problems when you want to pass a value that contains ":". Remove support for ":", it is now treated like any other normal character. This affects all options that are listed as "Key/value list" in the option list. It's possible that this breaks for someone who happened to use ":" as separator. But this was undocumented, and never recommended. Originally, the option treated many other characters in a special way, but this was changed in commit a3d561f950e74fe. I'm, not sure why ":" was explicitly included. Maybe because -the absurd -vf/--af syntax uses ":" as list separator. But "," was always recommended and used in examples for key/value options. Fixes: #8021 (if you consider it a bug) --- options/m_option.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'options') diff --git a/options/m_option.c b/options/m_option.c index 9b0fd82779..4d222df500 100644 --- a/options/m_option.c +++ b/options/m_option.c @@ -1710,7 +1710,7 @@ static int parse_keyvalue_list(struct mp_log *log, const m_option_t *opt, val = param; param.len = 0; } else { - r = read_subparam(log, name, ",:", ¶m, &val); + r = read_subparam(log, name, ",", ¶m, &val); if (r < 0) break; } -- cgit v1.2.3