From d890e0731c0a0c002c32e8be89130e178059d3ba Mon Sep 17 00:00:00 2001 From: wm4 Date: Fri, 20 Jan 2017 13:38:28 +0100 Subject: options: refactor how --opengl-dcomposition is declared vo_opengl used to have it as sub-option, which made it very hard to pass down option values to backends in a generic way (even if these options were completely backend-specific). For --opengl-dcomposition we used a VOFLAG to deal with this. Fortunately, sub-options are gone, and we can just add it as global option. Move the option to context_angle.c and add it as global option. I thought about adding a mechanism to let backends declare options, which would get magically picked up my m_config instead of having to add them to the global option list manually (similar to VO vo_driver.options), but decided against this complexity just for 1 or 2 backends. Likewise, it could have been added as a single option to avoid the boilerplate of an option struct, but then again there are probably going to be more angle suboptions, and it's cleaner. --- options/options.h | 1 + 1 file changed, 1 insertion(+) (limited to 'options/options.h') diff --git a/options/options.h b/options/options.h index d3b0ace24f..842781cb4b 100644 --- a/options/options.h +++ b/options/options.h @@ -320,6 +320,7 @@ typedef struct MPOpts { char *input_file; struct gl_video_opts *gl_video_opts; + struct angle_opts *angle_opts; struct dvd_opts *dvd_opts; } MPOpts; -- cgit v1.2.3