From 3d17e19c2c5ca80f916411e7e61126cac8443baa Mon Sep 17 00:00:00 2001 From: wm4 Date: Fri, 7 Feb 2020 00:50:25 +0100 Subject: options: disable vsfilter blur compat by default See #7435 and related for context. Basically, it seems that while the original vsfilter processed subtitles like with this option set to "yes", many current players (mpc-hc default, vlc, probably most libass users) treat them like with "no". In the linked issue, this makes rendering severely slower, and can consume a lot of memory (or just overflow libass memory calculations). It seems that changing this to "no" will lead to more good than bad, especially because newer subtitles may be authored for the "no" behavior. Most libass users seem to use "no" exactly because they do not call ass_set_storage_size() at all. This API was needed because the scaling of the subtitles depends on the video size (vsfilter bugs, or something). In addition, it's my personal opinion that rendering should not depend on the video at all, so I like setting the default of this to "no". --- options/options.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'options/options.c') diff --git a/options/options.c b/options/options.c index 41a307cffd..7eccfa03fb 100644 --- a/options/options.c +++ b/options/options.c @@ -255,7 +255,7 @@ const struct m_sub_options mp_subtitle_sub_opts = { .sub_scale = 1, .ass_vsfilter_aspect_compat = 1, .ass_vsfilter_color_compat = 1, - .ass_vsfilter_blur_compat = 1, + .ass_vsfilter_blur_compat = 0, .ass_style_override = 1, .ass_shaper = 1, .use_embedded_fonts = 1, -- cgit v1.2.3