From 37388ebb0ef9085c841d7f94e665a5a77cfe0e92 Mon Sep 17 00:00:00 2001 From: Stefano Pigozzi Date: Tue, 16 Jul 2013 13:28:28 +0200 Subject: configure: uniform the defines to #define HAVE_xxx (0|1) The configure followed 5 different convetions of defines because the next guy always wanted to introduce a new better way to uniform it[1]. For an hypothetic feature 'hurr' you could have had: * #define HAVE_HURR 1 / #undef HAVE_DURR * #define HAVE_HURR / #undef HAVE_DURR * #define CONFIG_HURR 1 / #undef CONFIG_DURR * #define HAVE_HURR 1 / #define HAVE_DURR 0 * #define CONFIG_HURR 1 / #define CONFIG_DURR 0 All is now uniform and uses: * #define HAVE_HURR 1 * #define HAVE_DURR 0 We like definining to 0 as opposed to `undef` bcause it can help spot typos and is very helpful when doing big reorganizations in the code. [1]: http://xkcd.com/927/ related --- mpvcore/player/video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'mpvcore/player/video.c') diff --git a/mpvcore/player/video.c b/mpvcore/player/video.c index a6e9f8aecb..8f57bd97ad 100644 --- a/mpvcore/player/video.c +++ b/mpvcore/player/video.c @@ -44,7 +44,7 @@ void update_fps(struct MPContext *mpctx) { -#ifdef CONFIG_ENCODING +#if HAVE_ENCODING struct sh_video *sh_video = mpctx->sh_video; if (mpctx->encode_lavc_ctx && sh_video) encode_lavc_set_video_fps(mpctx->encode_lavc_ctx, sh_video->fps); -- cgit v1.2.3