From b4d9647d189a6bb924fc6b415ae18969885f11f1 Mon Sep 17 00:00:00 2001 From: wm4 Date: Fri, 3 Aug 2012 05:55:02 +0200 Subject: mplayer: do not create X11 state in player frontend This is about the vo_x11_init_state() call. It basically opens a X11 connection. It's called in the main() function once. It's not really clear why this isn't done on VO creation instead. Maybe one reason was that --no-fixed-vo used to be the default: when playing a new file, the full VO state would be free'd and recreated. Keeping the X11 connection possibly improved things, although the question is how. In summary, there is no good reason to do this, and it only adds platform specific details to the player frontend. Do the X11 initialization in the respective VOs instead. --- mp_core.h | 1 - 1 file changed, 1 deletion(-) (limited to 'mp_core.h') diff --git a/mp_core.h b/mp_core.h index 70ad8a89a7..49cc81a8e1 100644 --- a/mp_core.h +++ b/mp_core.h @@ -82,7 +82,6 @@ struct chapter { typedef struct MPContext { struct MPOpts opts; struct m_config *mconfig; - struct vo_x11_state *x11_state; struct mp_fifo *key_fifo; struct input_ctx *input; struct osd_state *osd; -- cgit v1.2.3