From e7db4ccf1afbb6653ae1aae44b1c96c724361985 Mon Sep 17 00:00:00 2001 From: rathann Date: Thu, 9 Feb 2006 14:08:03 +0000 Subject: Patch by Stefan Huehner / stefan % huehner ! org \ MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit patch replaces '()' for the correct '(void)' in function declarations/prototypes which have no parameters. The '()' syntax tell thats there is a variable list of arguments, so that the compiler cannot check this. The extra CFLAG '-Wstrict-declarations' shows those cases. Comments about a similar patch applied to ffmpeg: That in C++ these mean the same, but in ANSI C the semantics are different; function() is an (obsolete) K&R C style forward declaration, it basically means that the function can have any number and any types of parameters, effectively completely preventing the compiler from doing any sort of type checking. -- Erik Slagter Defining functions with unspecified arguments is allowed but bad. With arguments unspecified the compiler can't report an error/warning if the function is called with incorrect arguments. -- Måns Rullgård git-svn-id: svn://svn.mplayerhq.hu/mplayer/trunk@17567 b3059339-0415-0410-9bf9-f77b7e298cf2 --- mp3lib/mp3.h | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) (limited to 'mp3lib/mp3.h') diff --git a/mp3lib/mp3.h b/mp3lib/mp3.h index 308c8187af..2e9a1312bc 100644 --- a/mp3lib/mp3.h +++ b/mp3lib/mp3.h @@ -9,11 +9,11 @@ extern void MP3_Init(); extern int MP3_Open(char *filename,int buffsize); extern void MP3_SeekFrame(int num,int dir); extern void MP3_SeekForward(int num); -extern int MP3_PrintTAG(); +extern int MP3_PrintTAG(void); extern int MP3_DecodeFrame(unsigned char *hova,short single); -extern int MP3_FillBuffers(); -extern void MP3_PrintHeader(); -extern void MP3_Close(); +extern int MP3_FillBuffers(void); +extern void MP3_PrintHeader(void); +extern void MP3_Close(void); /* public variables: */ extern int MP3_eof; // set if EOF reached extern int MP3_pause; // lock playing @@ -29,7 +29,7 @@ extern int MP3_bps; /* player level: */ extern int MP3_OpenDevice(char *devname); /* devname can be NULL for default) */ -extern void MP3_Play(); -extern void MP3_Stop(); -extern void MP3_CloseDevice(); +extern void MP3_Play(void); +extern void MP3_Stop(void); +extern void MP3_CloseDevice(void); -- cgit v1.2.3