From 8163b8d390a97fdedb1419c921ec89eee3c31b7e Mon Sep 17 00:00:00 2001
From: wm4 <wm4@nowhere>
Date: Tue, 13 Mar 2018 10:45:17 +0100
Subject: client API: deprecate qthelper.hpp

It's a WTF that we have something as specific in the API. It could be
argued that we should provide helpers for other language and GUI toolkit
combinations. Obviously that's not going to scale, and it's somewhat
likely that it will bitrot. The rest is said in the API changelog.
---
 libmpv/qthelper.hpp | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

(limited to 'libmpv')

diff --git a/libmpv/qthelper.hpp b/libmpv/qthelper.hpp
index bc30dec8a5..3af86e36e7 100644
--- a/libmpv/qthelper.hpp
+++ b/libmpv/qthelper.hpp
@@ -13,6 +13,15 @@
  * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
  */
 
+#ifndef MPV_CLIENT_API_QTHELPER_H_
+#define MPV_CLIENT_API_QTHELPER_H_
+
+#include <mpv/client.h>
+
+#if !MPV_ENABLE_DEPRECATED
+#error "This helper is deprecated. Copy it into your project instead."
+#else
+
 /**
  * Note: these helpers are provided for convenience for C++/Qt applications.
  * This is based on the public API in client.h, and it does not encode any
@@ -21,9 +30,6 @@
  * for other languages.
  */
 
-#ifndef MPV_CLIENT_API_QTHELPER_H_
-#define MPV_CLIENT_API_QTHELPER_H_
-
 #include <cstring>
 
 #include <QVariant>
@@ -33,8 +39,6 @@
 #include <QSharedPointer>
 #include <QMetaType>
 
-#include <mpv/client.h>
-
 namespace mpv {
 namespace qt {
 
@@ -377,4 +381,6 @@ static inline QVariant command(mpv_handle *ctx, const QVariant &args)
 
 Q_DECLARE_METATYPE(mpv::qt::ErrorReturn)
 
+#endif /* else #if MPV_ENABLE_DEPRECATED */
+
 #endif
-- 
cgit v1.2.3