From e7db4ccf1afbb6653ae1aae44b1c96c724361985 Mon Sep 17 00:00:00 2001 From: rathann Date: Thu, 9 Feb 2006 14:08:03 +0000 Subject: Patch by Stefan Huehner / stefan % huehner ! org \ MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit patch replaces '()' for the correct '(void)' in function declarations/prototypes which have no parameters. The '()' syntax tell thats there is a variable list of arguments, so that the compiler cannot check this. The extra CFLAG '-Wstrict-declarations' shows those cases. Comments about a similar patch applied to ffmpeg: That in C++ these mean the same, but in ANSI C the semantics are different; function() is an (obsolete) K&R C style forward declaration, it basically means that the function can have any number and any types of parameters, effectively completely preventing the compiler from doing any sort of type checking. -- Erik Slagter Defining functions with unspecified arguments is allowed but bad. With arguments unspecified the compiler can't report an error/warning if the function is called with incorrect arguments. -- Måns Rullgård git-svn-id: svn://svn.mplayerhq.hu/mplayer/trunk@17567 b3059339-0415-0410-9bf9-f77b7e298cf2 --- libmpeg2/motion_comp_mmx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'libmpeg2') diff --git a/libmpeg2/motion_comp_mmx.c b/libmpeg2/motion_comp_mmx.c index 9b73015d9b..8be581ad6a 100644 --- a/libmpeg2/motion_comp_mmx.c +++ b/libmpeg2/motion_comp_mmx.c @@ -67,7 +67,7 @@ static mmx_t round4 = {0x0002000200020002LL}; * unrolling will help */ -static inline void mmx_zero_reg () +static inline void mmx_zero_reg (void) { /* load 0 into mm0 */ pxor_r2r (mm0, mm0); -- cgit v1.2.3