From 3595dcc0896c6e3d117510b3361d75568cfa5f8e Mon Sep 17 00:00:00 2001 From: Uoti Urpala Date: Thu, 20 Oct 2011 01:58:43 +0300 Subject: audio/video: delete buggy "dynamic plugin" code Codec selection for audio and video decoding had a "dynamic plugin" feature that tried to load a shared library for any codec that had not been enabled at compilation (disabled by default, but could be enabled with --enable-dynamic-plugins configure switch; for unknown reasons some distro packages have enabled it). The implementation was buggy and could cause normal codec selection fallback to fail if the feature was enabled. I'm not aware of any real uses of such dynamic plugins and the feature seems questionable anyway (there are no ABI guarantees that would make it safe to use). Remove the buggy feature. --- libmpdemux/stheader.h | 6 ------ 1 file changed, 6 deletions(-) (limited to 'libmpdemux') diff --git a/libmpdemux/stheader.h b/libmpdemux/stheader.h index 80818e8785..06f52324e5 100644 --- a/libmpdemux/stheader.h +++ b/libmpdemux/stheader.h @@ -77,9 +77,6 @@ typedef struct sh_audio { int a_buffer_size; struct af_stream *afilter; // the audio filter stream const struct ad_functions *ad_driver; -#ifdef CONFIG_DYNAMIC_PLUGINS - void *dec_handle; -#endif // win32-compatible codec parameters: AVIStreamHeader audio; WAVEFORMATEX *wf; @@ -122,9 +119,6 @@ typedef struct sh_video { int output_flags; // query_format() results for output filters+vo const struct vd_functions *vd_driver; int vf_initialized; // -1 failed, 0 not done, 1 done -#ifdef CONFIG_DYNAMIC_PLUGINS - void *dec_handle; -#endif // win32-compatible codec parameters: AVIStreamHeader video; BITMAPINFOHEADER *bih; -- cgit v1.2.3