From 5fe4cdbdd07655f2beb72a45739b6724a183098d Mon Sep 17 00:00:00 2001 From: arpi Date: Tue, 27 Nov 2001 00:42:39 +0000 Subject: bad malloc+strcpy => strdup git-svn-id: svn://svn.mplayerhq.hu/mplayer/trunk@3151 b3059339-0415-0410-9bf9-f77b7e298cf2 --- libmpdemux/demuxer.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) (limited to 'libmpdemux/demuxer.c') diff --git a/libmpdemux/demuxer.c b/libmpdemux/demuxer.c index c03d49ccba..0beddd505e 100644 --- a/libmpdemux/demuxer.c +++ b/libmpdemux/demuxer.c @@ -2,6 +2,7 @@ #include #include +#include #include #include @@ -654,8 +655,7 @@ int demux_info_add(demuxer_t *demuxer, char *opt, char *param) mp_msg(MSGT_DEMUX, MSGL_WARN, "Demuxer info->name already present\n!"); return(0); } - info->name = malloc(strlen(param)); - strcpy(info->name, param); + info->name = strdup(param); return(1); } @@ -666,8 +666,7 @@ int demux_info_add(demuxer_t *demuxer, char *opt, char *param) mp_msg(MSGT_DEMUX, MSGL_WARN, "Demuxer info->author already present\n!"); return(0); } - info->author = malloc(strlen(param)); - strcpy(info->author, param); + info->author = strdup(param); return(1); } @@ -678,8 +677,7 @@ int demux_info_add(demuxer_t *demuxer, char *opt, char *param) mp_msg(MSGT_DEMUX, MSGL_WARN, "Demuxer info->encoder already present\n!"); return(0); } - info->encoder = malloc(strlen(param)); - strcpy(info->encoder, param); + info->encoder = strdup(param); return(1); } @@ -690,8 +688,7 @@ int demux_info_add(demuxer_t *demuxer, char *opt, char *param) mp_msg(MSGT_DEMUX, MSGL_WARN, "Demuxer info->comments already present\n!"); return(0); } - info->comments = malloc(strlen(param)); - strcpy(info->comments, param); + info->comments = strdup(param); return(1); } @@ -702,8 +699,7 @@ int demux_info_add(demuxer_t *demuxer, char *opt, char *param) mp_msg(MSGT_DEMUX, MSGL_WARN, "Demuxer info->copyright already present\n!"); return(0); } - info->copyright = malloc(strlen(param)); - strcpy(info->copyright, param); + info->copyright = strdup(param); return(1); } -- cgit v1.2.3