From aebfbbf2bdda8e18beef90c16da97bd335f7d3b0 Mon Sep 17 00:00:00 2001
From: wm4 <wm4@nowhere>
Date: Sun, 12 Aug 2012 15:30:21 +0200
Subject: Remove win32/qt/xanim/real binary codecs loading

Remove the win32 loader - the win32 emulation layer, as well as the
code for using DirectShow/DMO/VFW codecs. Remove loading of xanim,
QuickTime, and RealMedia codecs.

The win32 emulation layer is based on a very old version of wine.
Apparently, wine code was copied and hacked until it was somehow able
to load a limited collection of binary codecs. It poked around in the
code segment of some known binary codecs to disable unsupported win32
API calls to make them work. Example from module.c:

    for (i=0;i<5;i++)  RVA(0x19e842)[i]=0x90; // make_new_region ?
    for (i=0;i<28;i++) RVA(0x19e86d)[i]=0x90; // call__call_CreateCompatibleDC ?
    for (i=0;i<5;i++)  RVA(0x19e898)[i]=0x90; // jmp_to_call_loadbitmap ?
    for (i=0;i<9;i++)  RVA(0x19e8ac)[i]=0x90; // call__calls_OLE_shit ?
    for (i=0;i<106;i++) RVA(0x261b10)[i]=0x90; // disable threads

Just to show how utterly insane this code is. You wouldn't want even
your worst enemy to have to maintain this. In fact, it seems nobody
made major changes to this code ever since it was committed.

Most formats can be decoded by libavcodecs these days, and the loader
couldn't be used on 64 bit platforms anyway. The same is (probably)
true for the other binary codecs.

General note about how support for win32 codecs could be added back:

It's not possible to replace the win32 loader code by using wine as
library, because modern wine can not be linked with native Linux
programs for certain reasons. It would be possible to to move DirectShow
video decoding into a separate process linked with wine, like the
CoreAVC-for-Linux patches do. There is also the mplayer-ww fork, which
uses the dshownative library to use DirectShow codecs on Windows.
---
 libmpcodecs/vd.c | 20 --------------------
 1 file changed, 20 deletions(-)

(limited to 'libmpcodecs/vd.c')

diff --git a/libmpcodecs/vd.c b/libmpcodecs/vd.c
index a9dbbf2fe6..9594cfba24 100644
--- a/libmpcodecs/vd.c
+++ b/libmpcodecs/vd.c
@@ -39,13 +39,8 @@
 
 extern const vd_functions_t mpcodecs_vd_null;
 extern const vd_functions_t mpcodecs_vd_ffmpeg;
-extern const vd_functions_t mpcodecs_vd_dshow;
-extern const vd_functions_t mpcodecs_vd_dmo;
-extern const vd_functions_t mpcodecs_vd_vfw;
-extern const vd_functions_t mpcodecs_vd_vfwex;
 extern const vd_functions_t mpcodecs_vd_raw;
 extern const vd_functions_t mpcodecs_vd_hmblck;
-extern const vd_functions_t mpcodecs_vd_xanim;
 extern const vd_functions_t mpcodecs_vd_mpng;
 extern const vd_functions_t mpcodecs_vd_ijpg;
 extern const vd_functions_t mpcodecs_vd_mtga;
@@ -61,18 +56,9 @@ extern const vd_functions_t mpcodecs_vd_qtvideo;
 const vd_functions_t * const mpcodecs_vd_drivers[] = {
     &mpcodecs_vd_null,
     &mpcodecs_vd_ffmpeg,
-#ifdef CONFIG_WIN32DLL
-    &mpcodecs_vd_dshow,
-    &mpcodecs_vd_dmo,
-    &mpcodecs_vd_vfw,
-    &mpcodecs_vd_vfwex,
-#endif
     &mpcodecs_vd_lzo,
     &mpcodecs_vd_raw,
     &mpcodecs_vd_hmblck,
-#ifdef CONFIG_XANIM
-    &mpcodecs_vd_xanim,
-#endif
 #ifdef CONFIG_PNG
     &mpcodecs_vd_mpng,
 #endif
@@ -80,14 +66,8 @@ const vd_functions_t * const mpcodecs_vd_drivers[] = {
     &mpcodecs_vd_ijpg,
 #endif
     &mpcodecs_vd_mtga,
-#ifdef CONFIG_REALCODECS
-    &mpcodecs_vd_realvid,
-#endif
 #ifdef CONFIG_LIBDV095
     &mpcodecs_vd_libdv,
-#endif
-#ifdef CONFIG_QTX_CODECS
-    &mpcodecs_vd_qtvideo,
 #endif
     /* Please do not add any new decoders here. If you want to implement a new
      * decoder, add it to libavcodec, except for wrappers around external
-- 
cgit v1.2.3