From e7db4ccf1afbb6653ae1aae44b1c96c724361985 Mon Sep 17 00:00:00 2001 From: rathann Date: Thu, 9 Feb 2006 14:08:03 +0000 Subject: Patch by Stefan Huehner / stefan % huehner ! org \ MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit patch replaces '()' for the correct '(void)' in function declarations/prototypes which have no parameters. The '()' syntax tell thats there is a variable list of arguments, so that the compiler cannot check this. The extra CFLAG '-Wstrict-declarations' shows those cases. Comments about a similar patch applied to ffmpeg: That in C++ these mean the same, but in ANSI C the semantics are different; function() is an (obsolete) K&R C style forward declaration, it basically means that the function can have any number and any types of parameters, effectively completely preventing the compiler from doing any sort of type checking. -- Erik Slagter Defining functions with unspecified arguments is allowed but bad. With arguments unspecified the compiler can't report an error/warning if the function is called with incorrect arguments. -- Måns Rullgård git-svn-id: svn://svn.mplayerhq.hu/mplayer/trunk@17567 b3059339-0415-0410-9bf9-f77b7e298cf2 --- libfaad2/ps_dec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'libfaad2') diff --git a/libfaad2/ps_dec.c b/libfaad2/ps_dec.c index bdc2ee27a9..881a581658 100644 --- a/libfaad2/ps_dec.c +++ b/libfaad2/ps_dec.c @@ -159,7 +159,7 @@ typedef struct /* static function declarations */ static void ps_data_decode(ps_info *ps); -static hyb_info *hybrid_init(); +static hyb_info *hybrid_init(void); static void channel_filter2(hyb_info *hyb, uint8_t frame_len, const real_t *filter, qmf_t *buffer, qmf_t **X_hybrid); static void INLINE DCT3_4_unscaled(real_t *y, real_t *x); @@ -189,7 +189,7 @@ static void ps_mix_phase(ps_info *ps, qmf_t X_left[38][64], qmf_t X_right[38][64 /* */ -static hyb_info *hybrid_init() +static hyb_info *hybrid_init(void) { uint8_t i; -- cgit v1.2.3