From a56a7f3e8c7dbed38546f3ddedb0e26353f92e25 Mon Sep 17 00:00:00 2001 From: wm4 Date: Mon, 6 Jul 2015 00:08:29 +0200 Subject: ipc: fix undefined behavior in some error cases goto jumping over an initialization. --- input/ipc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'input') diff --git a/input/ipc.c b/input/ipc.c index ec219da31f..5ed057edb6 100644 --- a/input/ipc.c +++ b/input/ipc.c @@ -244,6 +244,7 @@ static char *json_execute_command(struct client_arg *arg, void *ta_parent, mpv_node msg_node; mpv_node reply_node = {.format = MPV_FORMAT_NODE_MAP, .u.list = NULL}; + mpv_node *reqid_node = NULL; rc = json_parse(ta_parent, &msg_node, &src, 3); if (rc < 0) { @@ -257,7 +258,7 @@ static char *json_execute_command(struct client_arg *arg, void *ta_parent, goto error; } - mpv_node *reqid_node = mpv_node_map_get(&msg_node, "request_id"); + reqid_node = mpv_node_map_get(&msg_node, "request_id"); mpv_node *cmd_node = mpv_node_map_get(&msg_node, "command"); if (!cmd_node || -- cgit v1.2.3