From f92c7fa807aa71f04de294afbe9745f7784a645c Mon Sep 17 00:00:00 2001 From: wm4 Date: Mon, 23 Mar 2015 18:24:28 +0100 Subject: demux_mkv_timeline: don't continue if reopening file failed Could theoretically dereference "d" later in the loop. It's on an error codepath, so just give up. --- demux/demux_mkv_timeline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'demux') diff --git a/demux/demux_mkv_timeline.c b/demux/demux_mkv_timeline.c index 3326362226..09e411eda7 100644 --- a/demux/demux_mkv_timeline.c +++ b/demux/demux_mkv_timeline.c @@ -217,7 +217,7 @@ static bool check_file_seg(struct tl_ctx *ctx, char *filename, int segment) params.matroska_wanted_uids = ctx->uids; // potentially reallocated, same data d = demux_open_url(filename, ¶ms, cancel, ctx->global); if (!d) - continue; + return false; } ctx->sources[i] = d; -- cgit v1.2.3