From 90e4c8589140e5be411f1f169542e1f135ceeefa Mon Sep 17 00:00:00 2001
From: wm4 <wm4@nowhere>
Date: Sun, 22 Dec 2013 23:44:24 +0100
Subject: subreader: remove overlapping strcpy

Looks like this relied on undefined behavior.
---
 demux/demux_subreader.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

(limited to 'demux')

diff --git a/demux/demux_subreader.c b/demux/demux_subreader.c
index fa029655fc..2969e1b3b8 100644
--- a/demux/demux_subreader.c
+++ b/demux/demux_subreader.c
@@ -127,7 +127,8 @@ static int eol(char p) {
 static void trail_space(char *s) {
 	int i = 0;
 	while (isspace(s[i])) ++i;
-	if (i) strcpy(s, s + i);
+        int copylen = strlen(s + i);
+	if (i) memmove(s, s + i, copylen);
 	i = strlen(s) - 1;
 	while (i > 0 && isspace(s[i])) s[i--] = '\0';
 }
-- 
cgit v1.2.3