From 897d1c01bca01bf874d4cd45a9bb4fc9b2b2806f Mon Sep 17 00:00:00 2001
From: wm4 <wm4@nowhere>
Date: Sun, 29 Jul 2012 18:00:41 +0200
Subject: mplayer: remove crash handler stuff

mplayer tries to catch all signals by default, and displays a "nice"
crash message if a signal is caught. This is mostly useless for
diagnosing problems, and it's extremely fragile. It's likely to cause
more harm than it possibly solves.

Also remove the current_module variable, which was supposed to give a
hint which submodule was being run. This was far from accurate or
useful.

mplayer also caught SIG_CHILD, and tried to wait for any children. This
potentially gets rid of zombies, but I'm not sure which ones. The only
places that fork(), cache2.c and unrar_exec.c, seem to wait for their
child processes properly. Just get rid of it.

Note that we don't even catch SIGTERM. Maybe this will have to be added
back in order to re-enable screensavers and such when the user
terminates mplayer with ^C on the terminal.
---
 configure | 28 ----------------------------
 1 file changed, 28 deletions(-)

(limited to 'configure')

diff --git a/configure b/configure
index 68aebc2675..298e30eb22 100755
--- a/configure
+++ b/configure
@@ -434,8 +434,6 @@ Advanced options:
   --enable-shm              enable shm [autodetect]
   --enable-debug[=1-3]      compile-in debugging information [disable]
   --enable-profile          compile-in profiling information [disable]
-  --disable-sighandler      disable sighandler for crashes [enable]
-  --enable-crash-debug      enable automatic gdb attach on crash [disable]
 
 Use these options if autodetection fails:
   --extra-cflags=FLAGS        extra CFLAGS
@@ -560,8 +558,6 @@ _directfb=auto
 _shm=auto
 _translation=no
 _charset="UTF-8"
-_crash_debug=no
-_sighandler=yes
 _libdv=auto
 _cdda=auto
 _cddb=auto
@@ -926,10 +922,6 @@ for ac_option do
   --enable-sortsub) _sortsub=yes ;;
   --disable-sortsub) _sortsub=no ;;
 
-  --enable-crash-debug) _crash_debug=yes ;;
-  --disable-crash-debug) _crash_debug=no ;;
-  --enable-sighandler)  _sighandler=yes  ;;
-  --disable-sighandler) _sighandler=no   ;;
   --enable-win32dll) _win32dll=yes ;;
   --disable-win32dll) _win32dll=no ;;
 
@@ -1500,15 +1492,6 @@ language_msg=$tmp_language_msg
 echores "messages (en+): $language_msg - man pages: $language_man - documentation: $language_doc"
 
 
-echocheck "enable sighandler"
-if test "$_sighandler" = yes ; then
-  def_sighandler='#define CONFIG_SIGHANDLER 1'
-else
-  def_sighandler='#undef CONFIG_SIGHANDLER'
-fi
-echores "$_sighandler"
-
-
 echocheck "restrict keyword"
 for restrict_keyword in restrict __restrict __restrict__ ; do
   echo "void foo(char * $restrict_keyword p); int main(void) { return 0; }" > $TMPC
@@ -4237,15 +4220,6 @@ fi
 
 #############################################################################
 
-echocheck "automatic gdb attach"
-if test "$_crash_debug" = yes ; then
-  def_crash_debug='#define CONFIG_CRASH_DEBUG 1'
-else
-  def_crash_debug='#undef CONFIG_CRASH_DEBUG'
-  _crash_debug=no
-fi
-echores "$_crash_debug"
-
 echocheck "compiler support for noexecstack"
 if cflag_check -Wl,-z,noexecstack ; then
   extra_ldflags="-Wl,-z,noexecstack $extra_ldflags"
@@ -4681,9 +4655,7 @@ $def_unrar_exec
 
 /* configurable options */
 $def_charset
-$def_crash_debug
 $def_debug
-$def_sighandler
 $def_sortsub
 $def_stream_cache
 $def_pthread_cache
-- 
cgit v1.2.3