From a85fa2d2de92a89258da6b8bf6d814cf47824a0e Mon Sep 17 00:00:00 2001 From: wm4 Date: Fri, 11 Oct 2019 21:28:04 +0200 Subject: player: accept compatible later FFmpeg library runtime versions mpv warned if the FFmpeg runtime library version was not exactly the same as the build version. This seemed to cause frequent conflicts. At this point, most mpv code probably adheres to the FFmpeg ABI rules, and FFmpeg stopped breaking ABI "accidentally". Another source of problems were mixed FFmpeg/Libav installations, something which nobody does anymore. It's not "our" job to check and enforce ABI compatibility either. So I guess this behavior can be removed. OK, still check for incompatible libraries (according to FFmpeg versioning rules), i.e. different major versions, or if the build version is newer than the runtime version. For now. The comment about ABI problems is still true. In particular, the bytes_read field mentioned in the removed comment is still accessed, and is still an ABI violation. Have fun. --- common/av_log.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'common') diff --git a/common/av_log.c b/common/av_log.c index a9a5171795..8b0cb09efa 100644 --- a/common/av_log.c +++ b/common/av_log.c @@ -210,7 +210,8 @@ bool print_libav_versions(struct mp_log *log, int v) mp_msg(log, v, " %-15s %d.%d.%d", l->name, V(l->buildv)); if (l->buildv != l->runv) { mp_msg(log, v, " (runtime %d.%d.%d)", V(l->runv)); - mismatch = true; + mismatch = l->buildv > l->runv || + AV_VERSION_MAJOR(l->buildv) != AV_VERSION_MAJOR(l->runv); } mp_msg(log, v, "\n"); } -- cgit v1.2.3