From 77869e5914d306d49d605ce0734b2a6145d02089 Mon Sep 17 00:00:00 2001 From: wm4 Date: Fri, 10 Apr 2015 13:51:13 +0200 Subject: ao_coreaudio: fix inverted condition And also use the correct type for the printf call below. --- audio/out/ao_coreaudio_utils.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'audio') diff --git a/audio/out/ao_coreaudio_utils.c b/audio/out/ao_coreaudio_utils.c index 8485011722..d606587866 100644 --- a/audio/out/ao_coreaudio_utils.c +++ b/audio/out/ao_coreaudio_utils.c @@ -141,16 +141,17 @@ char *fourcc_repr(void *talloc_ctx, uint32_t code) }; bool valid_fourcc = true; - for (int i = 0; i < 4; i++) - if (fcc[i] >= 32 && fcc[i] < 128) + for (int i = 0; i < 4; i++) { + if (fcc[i] < 32 || fcc[i] >= 128) valid_fourcc = false; + } char *repr; if (valid_fourcc) repr = talloc_asprintf(talloc_ctx, "'%c%c%c%c'", fcc[0], fcc[1], fcc[2], fcc[3]); else - repr = talloc_asprintf(NULL, "%d", code); + repr = talloc_asprintf(NULL, "%u", (unsigned int)code); return repr; } -- cgit v1.2.3