From 3b0b89c0affa858d5ed23f7ea618bde9ff2106cf Mon Sep 17 00:00:00 2001 From: Kevin Mitchell Date: Fri, 28 Nov 2014 10:12:35 -0800 Subject: ao/wasapi: just return 0 unconditionally from the thread We weren't actually checking this value anyway. We only really cared about init failure, which was checked another way. --- audio/out/ao_wasapi.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) (limited to 'audio') diff --git a/audio/out/ao_wasapi.c b/audio/out/ao_wasapi.c index 30767549fd..666cda557e 100644 --- a/audio/out/ao_wasapi.c +++ b/audio/out/ao_wasapi.c @@ -120,18 +120,14 @@ static DWORD __stdcall ThreadLoop(void *lpParameter) { struct ao *ao = lpParameter; if (!ao || !ao->priv) - return -1; + return 1; struct wasapi_state *state = (struct wasapi_state *)ao->priv; - int thread_ret; CoInitializeEx(NULL, COINIT_APARTMENTTHREADED); state->init_ret = wasapi_thread_init(ao); SetEvent(state->init_done); - if (state->init_ret != S_OK) { - thread_ret = -1; + if (state->init_ret != S_OK) goto exit_label; - } - DWORD waitstatus; HANDLE playcontrol[] = @@ -143,7 +139,6 @@ static DWORD __stdcall ThreadLoop(void *lpParameter) switch (waitstatus) { case WAIT_OBJECT_0: /*shutdown*/ MP_DBG(ao, "Thread shutdown\n"); - thread_ret = 0; goto exit_label; case (WAIT_OBJECT_0 + 1): /* feed */ thread_feed(ao); @@ -158,7 +153,6 @@ static DWORD __stdcall ThreadLoop(void *lpParameter) break; default: MP_ERR(ao, "Unhandled case in thread loop"); - thread_ret = -1; goto exit_label; } } @@ -166,8 +160,8 @@ exit_label: wasapi_thread_uninit(ao); CoUninitialize(); - MP_DBG(ao, "Thread return %u\n", (unsigned)thread_ret); - return thread_ret; + MP_DBG(ao, "Thread return\n"); + return 0; } static void closehandles(struct ao *ao) -- cgit v1.2.3