From 66a958bb4fa43c2fcc7362baed6c85f4f871b00d Mon Sep 17 00:00:00 2001 From: wm4 Date: Tue, 26 Apr 2016 18:35:37 +0200 Subject: ao_coreaudio: remove detected_device Setting this here is a race condition. It's called from a CoreAudio callbacks, and there are no locks. It's a string, so this can be potentially severe. It's hard to fix and only CoreAudio supported it, so remove it. This causes the "audio-out-detected-device" property to return nothing on all platforms. --- audio/out/ao_coreaudio.c | 5 ----- 1 file changed, 5 deletions(-) (limited to 'audio/out') diff --git a/audio/out/ao_coreaudio.c b/audio/out/ao_coreaudio.c index 471ab6d928..b0a5dc0da1 100644 --- a/audio/out/ao_coreaudio.c +++ b/audio/out/ao_coreaudio.c @@ -133,11 +133,6 @@ static bool reinit_device(struct ao *ao) { OSStatus err = ca_select_device(ao, ao->device, &p->device); CHECK_CA_ERROR("failed to select device"); - char *uid; - err = CA_GET_STR(p->device, kAudioDevicePropertyDeviceUID, &uid); - CHECK_CA_ERROR("failed to get device UID"); - ao->detected_device = talloc_steal(ao, uid); - return true; coreaudio_error: -- cgit v1.2.3