From dc48893630d11829121a45137460afb45e24ef2d Mon Sep 17 00:00:00 2001 From: wm4 Date: Sat, 17 Sep 2016 18:07:40 +0200 Subject: options: simplify M_OPT_EXIT There were multiple values under M_OPT_EXIT (M_OPT_EXIT-n for n>=0). Somehow M_OPT_EXIT-n either meant error code n (with n==0 no error?), or the number of option valus consumed (0 or 1). The latter is MPlayer legacy, which left it to the option type parsers to determine whether an option took a value or not. All of this was changed in mpv, by requiring the user to use explicit syntax ("--opt=val" instead of "-opt val"). In any case, the n value wasn't even used (anymore), so rip this all out. Now M_OPT_EXIT-1 doesn't mean anything, and could be used by a new error code. --- audio/out/ao_openal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'audio/out/ao_openal.c') diff --git a/audio/out/ao_openal.c b/audio/out/ao_openal.c index 2c29b8923b..237226e4a5 100644 --- a/audio/out/ao_openal.c +++ b/audio/out/ao_openal.c @@ -96,7 +96,7 @@ static int validate_device_opt(struct mp_log *log, const m_option_t *opt, mp_info(log, " '%s'\n", list); list = list + strlen(list) + 1; } - return M_OPT_EXIT - 1; + return M_OPT_EXIT; } return 0; } -- cgit v1.2.3