From 46e3dc27af20492dd24d228781b895f25abc3438 Mon Sep 17 00:00:00 2001 From: wm4 Date: Sat, 18 Mar 2017 15:03:05 +0100 Subject: screenshot: change details of --screenshot-format handling This is just a pointless refactor with the only goal of making image_writer_opts.format a number. The pointless part of it is that instead of using some sort of arbitrary ID (in place of a file extension string), we use a AV_CODEC_ID_. There was also some idea of falling back to the libavcodec MJPEG encoder if mpv was not linked against libjpeg, but this fails. libavcodec insist on having AV_PIX_FMT_YUVJ420P, which we pretend does not exist, and which we always map to AV_PIX_FMT_YUV420P (without the J indicating full range), so encoder init fails. This is pretty dumb, but whatever. The not-caring factor is raised by the fact that we don't know that we should convert to full range, because encoders have no proper way to signal this. (Be reminded that AV_PIX_FMT_YUVJ420P is deprecated.) --- DOCS/interface-changes.rst | 1 + DOCS/man/options.rst | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) (limited to 'DOCS') diff --git a/DOCS/interface-changes.rst b/DOCS/interface-changes.rst index 76c8e5f596..c82b0a62d0 100644 --- a/DOCS/interface-changes.rst +++ b/DOCS/interface-changes.rst @@ -24,6 +24,7 @@ Interface changes (see git "vo_opengl: remove dxva2 dummy hwdec backend") - remove ppm, pgm, pgmyuv, tga choices from the --screenshot-format and --vo-image-format options + - the "jpeg" choice in the option above now leads to a ".jpg" file extension --- mpv 0.24.0 --- - deprecate --hwdec-api and replace it with --opengl-hwdec-interop. The new option accepts both --hwdec values, as well as named backends. diff --git a/DOCS/man/options.rst b/DOCS/man/options.rst index 469ed29c44..4ee702df61 100644 --- a/DOCS/man/options.rst +++ b/DOCS/man/options.rst @@ -3108,7 +3108,7 @@ Screenshot :png: PNG :jpg: JPEG (default) - :jpeg: JPEG (same as jpg, but with .jpeg file ending) + :jpeg: JPEG (alias for jpg) ``--screenshot-tag-colorspace=`` Tag screenshots with the appropriate colorspace. -- cgit v1.2.3