From e48b21dd87468245268c470b250c3cdd5a1bbfae Mon Sep 17 00:00:00 2001 From: wm4 Date: Thu, 2 Aug 2012 21:28:59 +0200 Subject: VO: remove VO direct rendering This was disabled by default, and could be enabled with -dr. It was disabled by default because it was buggy: there were issues with OSD corruption. It wasn't entirely sane for OpenGL based VOs either. OpenGL can chose to drop mapped pixel buffer objects, requiring the application to map and fill the buffer again. But there was no mechanism in mplayer to fill the lost buffer again. (It seems this rarely happened in practice, though.) On the other side, users liked the --dr flag, because it promised them more speed. I'm not sure if it actually helped with speed, but it's unlikely it had any real advantages on modern systems. In order to evade the --dr cargo culting in mplayer config files, it's best to get rid of it. --- DOCS/man/en/options.rst | 5 ----- DOCS/man/en/vo.rst | 4 ++-- 2 files changed, 2 insertions(+), 7 deletions(-) (limited to 'DOCS/man') diff --git a/DOCS/man/en/options.rst b/DOCS/man/en/options.rst index 2f507f98f2..1fd96565a4 100644 --- a/DOCS/man/en/options.rst +++ b/DOCS/man/en/options.rst @@ -514,11 +514,6 @@ double-click (default: 300). Set to 0 to let your windowing system decide what a double-click is (``--vo=directx`` only). ---dr - Turns on direct rendering (not supported by all codecs and video outputs) - - *WARNING*: May cause OSD/SUB corruption! - --dumpfile= Specify which file MPlayer should dump to. Should be used together with ``--dumpaudio`` / ``--dumpvideo`` / ``--dumpstream`` / ``--capture``. diff --git a/DOCS/man/en/vo.rst b/DOCS/man/en/vo.rst index 01224bae65..6fbc5aefb6 100644 --- a/DOCS/man/en/vo.rst +++ b/DOCS/man/en/vo.rst @@ -172,7 +172,7 @@ gl than the maximum texture size of your OpenGL implementation. Intended to work even with the most basic OpenGL implementations, but also makes use of newer extensions, which allow support for more colorspaces and direct - rendering. For optimal speed try adding the options ``--dr=-noslices`` + rendering. The code performs very few checks, so if a feature does not work, this might be because it is not supported by your card/OpenGL implementation @@ -181,7 +181,7 @@ gl (no-)ati-hack ATI drivers may give a corrupted image when PBOs are used (when using - ``--dr`` or `force-pbo`). This option fixes this, at the expense of + `force-pbo`). This option fixes this, at the expense of using a bit more memory. (no-)force-pbo Always uses PBOs to transfer textures even if this involves an extra -- cgit v1.2.3