From 7dd69ef77c6aa80067c13f76aa0b78d63fbc4eda Mon Sep 17 00:00:00 2001 From: wm4 Date: Sat, 28 Apr 2018 18:14:43 +0200 Subject: command: change cycle-value command behavior Instead of using an internal counter to keep track of the value that was set last, attempt to find the current value of the property/option in the value list, and then set the next value in the list. There are some potential problems. If a property refuses to accept a specific value, the cycle-values command will fail, and start from the same position again. It can't know that it's supposed to skip the next value. The same can happen to properties which behave "strangely", such as the "aspect" property, which will return the current aspect if you write "-1" to it. As a consequence, cycle-values can appear to get "stuck". I still think the new behavior is what users expect more, and which is generally more useful. We won't restore the ability to get the old behavior, unless we decide to revert this commit entirely. Fixes #5772, and hopefully other complaints. --- DOCS/man/options.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'DOCS/man/options.rst') diff --git a/DOCS/man/options.rst b/DOCS/man/options.rst index 069363dfd0..d147800ea3 100644 --- a/DOCS/man/options.rst +++ b/DOCS/man/options.rst @@ -2249,7 +2249,7 @@ Window .. admonition:: Note (X11) - This option does works properly only with window managers which + This option works properly only with window managers which understand the EWMH ``_NET_WM_FULLSCREEN_MONITORS`` hint. .. admonition:: Note (OS X) -- cgit v1.2.3