From d3e3bd43074ddd8f4c8829a7454b9f855454f462 Mon Sep 17 00:00:00 2001 From: wm4 Date: Wed, 18 Dec 2019 05:11:57 +0100 Subject: options: increase consistency between list options and document them Whenever I deal with this, I have to look at the code to make sense of this. And beyond that, there are some strange inconsistencies. (I think this code is cursed. It always was, and maybe always will be.) Although the manpage claimed that using multiple items for -add etc. is deprecated, string list options didn't warn against it. So add the warning, and add something in the changelog (even though nobody will ever read this). The manpage mentioned --vf-append, but this didn't even exist. So add it, I guess. We encourage using -append for the other option types, so for consistency, it should work on filter options. (And I already tricked me into believing it existed when I mentioned it in the manpage.) Make the "operations" table separate for all option types, and mention the option type on every single of the top-level list options. --- DOCS/interface-changes.rst | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'DOCS/interface-changes.rst') diff --git a/DOCS/interface-changes.rst b/DOCS/interface-changes.rst index f12e6ed54a..8926d63f08 100644 --- a/DOCS/interface-changes.rst +++ b/DOCS/interface-changes.rst @@ -71,6 +71,10 @@ Interface changes instead of the actual size of the window. The new "current-window-scale" property needs to be queried to read the value as indicated by the current window size. This is a breaking change. + - explicitly deprecate passing more than 1 item to "-add" suffix in key/value + options (for example --script-opts-add). This was actually always + deprecated, like with other list options, but the option parser did not + print a warning in this particular case. --- mpv 0.30.0 --- - add `--d3d11-output-format` to enable explicit selection of a D3D11 swap chain format. -- cgit v1.2.3