From 37f441d61b1e2f92a31fe8f71dc965254d8e0d95 Mon Sep 17 00:00:00 2001 From: wm4 Date: Sun, 22 Mar 2020 19:42:59 +0100 Subject: lua: restore recent end-file event, and deprecate it Lua changed behavior for this specific event. I considered the change minor enough that it would not need to go through deprecation, but someone hit it immediately and ask on the -dev channel. It's probably better to restore the behavior. But mark it as deprecated, since it's problematic (mismatch with the C API). Unfortunately, no automatic warning is possible. (Or maybe it is, by playing sophisticated Lua tricks such as setting a metatable and overriding indexing, but let's not.) --- DOCS/interface-changes.rst | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'DOCS/interface-changes.rst') diff --git a/DOCS/interface-changes.rst b/DOCS/interface-changes.rst index 2290c6c6b1..5b1ab8602f 100644 --- a/DOCS/interface-changes.rst +++ b/DOCS/interface-changes.rst @@ -54,8 +54,10 @@ Interface changes Using the "playlist-play-index" command is recommended instead. - add "playlist-play-index" command - add playlist-current-pos, playlist-playing-pos properties - - Lua end-file events do not set the "error" field anymore, use "file_error" - instead. + - Lua end-file events set the "error" field; this is deprecated; use the + "file_error" instead for this specific event. Scripts relying on the + "error" field for end-file will silently break at some point in the + future. - deprecate encoding mode (lack of maintainer) --- mpv 0.32.0 --- - change behavior when using legacy option syntax with options that start -- cgit v1.2.3