From faf561c4ec3192e0dcef243110c88799cf4dee6a Mon Sep 17 00:00:00 2001 From: wm4 Date: Tue, 13 Jan 2015 14:26:25 +0100 Subject: mp_image: reject invalid display aspect ratio Having any of these set to 0 makes no sense. I think some code might still be using 0/0 aspect ratio to signal unset aspect ratio, but I didn't find it. If there is still code like this, it should be fixed instead. Fixes #1467. --- video/mp_image.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/video/mp_image.c b/video/mp_image.c index abf608d1fe..33bbd31668 100644 --- a/video/mp_image.c +++ b/video/mp_image.c @@ -496,7 +496,7 @@ bool mp_image_params_valid(const struct mp_image_params *p) if (p->w < 0 || p->h < 0 || (p->w + 128LL) * (p->h + 128LL) >= INT_MAX / 8) return false; - if (p->d_w < 0 || p->d_h < 0) + if (p->d_w <= 0 || p->d_h <= 0) return false; if (p->rotate < 0 || p->rotate >= 360) -- cgit v1.2.3