From ec3c428e5fb03244b9f8f4f7432779b45a181166 Mon Sep 17 00:00:00 2001 From: wm4 Date: Wed, 31 Aug 2016 22:25:06 +0200 Subject: stream_cb: remove broken cast seek_fn is supposed to return the new file offset, or a negative error code. Our code doesn't use the offset, and only wants to know if any errors happened. The int cast is completely broken and might treat a successful seek as failed depending on whether the sign bit will be set. --- stream/stream_cb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stream/stream_cb.c b/stream/stream_cb.c index 4496e63255..fdef517bb8 100644 --- a/stream/stream_cb.c +++ b/stream/stream_cb.c @@ -31,7 +31,7 @@ static int fill_buffer(stream_t *s, char *buffer, int max_len) static int seek(stream_t *s, int64_t newpos) { struct priv *p = s->priv; - return (int)p->info.seek_fn(p->info.cookie, newpos) >= 0; + return p->info.seek_fn(p->info.cookie, newpos) >= 0; } static int control(stream_t *s, int cmd, void *arg) -- cgit v1.2.3