From cd8fd4b7886e65e89e29c309bf5145bc31c909ab Mon Sep 17 00:00:00 2001 From: wm4 Date: Fri, 8 Nov 2019 18:56:57 +0100 Subject: vo_gpu: context_x11egl: check eglGetConfigAttrib() for errors Not sure why it assumes that it always succeeds (although generally it won't fail). --- video/out/opengl/context_x11egl.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/video/out/opengl/context_x11egl.c b/video/out/opengl/context_x11egl.c index b1aa0690d7..f0cfe378f1 100644 --- a/video/out/opengl/context_x11egl.c +++ b/video/out/opengl/context_x11egl.c @@ -125,7 +125,10 @@ static bool mpegl_init(struct ra_ctx *ctx) goto uninit; int vID, n; - eglGetConfigAttrib(p->egl_display, config, EGL_NATIVE_VISUAL_ID, &vID); + if (!eglGetConfigAttrib(p->egl_display, config, EGL_NATIVE_VISUAL_ID, &vID)) { + MP_FATAL(ctx, "Getting X visual ID failed!\n"); + goto uninit; + } MP_VERBOSE(ctx, "chose visual 0x%x\n", vID); XVisualInfo template = {.visualid = vID}; XVisualInfo *vi = XGetVisualInfo(vo->x11->display, VisualIDMask, &template, &n); -- cgit v1.2.3