From cd24fdcd5a1acd8e6115814f5a0180224c1af7ed Mon Sep 17 00:00:00 2001 From: wm4 Date: Sat, 19 Dec 2015 16:26:36 +0100 Subject: vo_opengl: disable pbo by defaults for opengl-hq Too many problems. --- DOCS/man/vo.rst | 12 +++++++----- video/out/opengl/video.c | 1 - 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/DOCS/man/vo.rst b/DOCS/man/vo.rst index 6335b34583..0b3742c4d7 100644 --- a/DOCS/man/vo.rst +++ b/DOCS/man/vo.rst @@ -447,10 +447,12 @@ Available video output drivers are: Note that this option never affects ``cscale``. ``pbo`` - Enable use of PBOs. This is slightly faster, but can sometimes lead to - sporadic and temporary image corruption (in theory, because reupload - is not retried when it fails), and perhaps actually triggers slower - paths with drivers that don't support PBOs properly. + Enable use of PBOs. On some drivers this can be faster, especially if + the source video size is huge (e.g. so called "4K" video). On other + drivers it might be slower or cause latency issues. + + In theory, this can sometimes lead to sporadic and temporary image + corruption (because reupload is not retried when it fails). ``dither-depth=`` Set dither target depth to N. Default: no. @@ -984,7 +986,7 @@ Available video output drivers are: This is equivalent to:: - --vo=opengl:scale=spline36:cscale=spline36:dscale=mitchell:dither-depth=auto:correct-downscaling:sigmoid-upscaling:pbo:deband:es=no + --vo=opengl:scale=spline36:cscale=spline36:dscale=mitchell:dither-depth=auto:correct-downscaling:sigmoid-upscaling:deband:es=no Note that some cheaper LCDs do dithering that gravely interferes with ``opengl``'s dithering. Disabling dithering with ``dither-depth=no`` helps. diff --git a/video/out/opengl/video.c b/video/out/opengl/video.c index b2dd4564d0..7266d1063a 100644 --- a/video/out/opengl/video.c +++ b/video/out/opengl/video.c @@ -373,7 +373,6 @@ const struct gl_video_opts gl_video_opts_hq_def = { .background = {0, 0, 0, 255}, .gamma = 1.0f, .blend_subs = 0, - .pbo = 1, .deband = 1, .prescale_passes = 1, .prescale_downscaling_threshold = 2.0f, -- cgit v1.2.3