From b7f242dfcf600b6ec8a861218df5fc0b71217455 Mon Sep 17 00:00:00 2001 From: wm4 Date: Mon, 9 Mar 2015 11:46:16 +0100 Subject: x11: fix VOCTRL_GET_WIN_STATE Do not rely on the pointed-to argument to be initialized; VOCTRLs are supposed to completely overwrite them on success (or not to touch them on failure). The currently only caller of VOCTRL_GET_WIN_STATE initializes the value before calling this, so this is merely about correctness and didn't lead to any actual bugs. --- video/out/x11_common.c | 1 + 1 file changed, 1 insertion(+) diff --git a/video/out/x11_common.c b/video/out/x11_common.c index 3ae753a234..2fef802ae8 100644 --- a/video/out/x11_common.c +++ b/video/out/x11_common.c @@ -1675,6 +1675,7 @@ int vo_x11_control(struct vo *vo, int *events, int request, void *arg) case VOCTRL_GET_WIN_STATE: { if (!x11->pseudo_mapped) return VO_FALSE; + *(int *)arg = 0; int num_elems; long *elems = x11_get_property(x11, x11->window, XA(x11, _NET_WM_STATE), XA_ATOM, 32, &num_elems); -- cgit v1.2.3