From a37c81017320997dc7bcf8d290b31851c4b19bb5 Mon Sep 17 00:00:00 2001 From: wm4 Date: Wed, 23 Oct 2013 17:50:49 +0200 Subject: vo_opengl: don't enable PBOs with opengl-hq The speed advantages are marginal (at least with the way it's currently used), and it might actually be slower on some drivers, like Mesa. --- DOCS/man/en/vo.rst | 8 +++++--- video/out/vo_opengl.c | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/DOCS/man/en/vo.rst b/DOCS/man/en/vo.rst index 27141982c0..4590ec33f2 100644 --- a/DOCS/man/en/vo.rst +++ b/DOCS/man/en/vo.rst @@ -320,8 +320,10 @@ Available video output drivers are: slightly different gamma. ``pbo`` - Enable use of PBOs. This is faster, but can sometimes lead to sporadic - and temporary image corruption. + Enable use of PBOs. This is slightly faster, but can sometimes lead to + sporadic and temporary image corruption (in theory, because reupload + is not retried when it fails), and perhaps actually triggers slower + paths with drivers that don't support PBOs properly. ``dither-depth=`` Set dither target depth to N. Default: no. @@ -478,7 +480,7 @@ Available video output drivers are: This is equivalent to:: - --vo=opengl:lscale=lanczos2:dither-depth=auto:pbo:fbo-format=rgb16 + --vo=opengl:lscale=lanczos2:dither-depth=auto:fbo-format=rgb16 Note that some cheaper LCDs do dithering that gravely interferes with ``opengl``'s dithering. Disabling dithering with ``dither-depth=no`` helps. diff --git a/video/out/vo_opengl.c b/video/out/vo_opengl.c index 03d1689667..4a67231770 100644 --- a/video/out/vo_opengl.c +++ b/video/out/vo_opengl.c @@ -383,5 +383,5 @@ const struct vo_driver video_out_opengl_hq = { .uninit = uninit, .priv_size = sizeof(struct gl_priv), .options = options, - .init_option_string = "lscale=lanczos2:dither-depth=auto:pbo:fbo-format=rgb16", + .init_option_string = "lscale=lanczos2:dither-depth=auto:fbo-format=rgb16", }; -- cgit v1.2.3