From 94140e08971822b75168cac014fa037f76db3828 Mon Sep 17 00:00:00 2001 From: wm4 Date: Sat, 30 Aug 2014 23:54:19 +0200 Subject: csputils: adjust comment Make it clear that the value is linked to the StereoMode element. You can't change this without adjusting demux_mkv.c. --- video/csputils.c | 6 +++--- video/csputils.h | 2 ++ 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/video/csputils.c b/video/csputils.c index d07b3a096e..f5121b76ec 100644 --- a/video/csputils.c +++ b/video/csputils.c @@ -79,8 +79,8 @@ const char *const mp_chroma_names[MP_CHROMA_COUNT] = { // The short name _must_ match with what vf_stereo3d accepts (if supported). // The long name is closer to the Matroska spec (StereoMode element). -// If you add entries that don't match Matroska, make sure demux_mkv.c rejects -// them properly. +// The numeric index matches the Matroska StereoMode value. If you add entries +// that don't match Matroska, make sure demux_mkv.c rejects them properly. // The long name is unused. #define E(index, short, long) [index] = short const char *const mp_stereo3d_names[MP_STEREO3D_COUNT] = { @@ -89,7 +89,7 @@ const char *const mp_stereo3d_names[MP_STEREO3D_COUNT] = { E(2, "abr", "top_bottom_right"), E(3, "abl", "top_bottom_left"), E(4, "checkr", "checkboard_right"), // unsupported by vf_stereo3d - E(5, "checkl", "checkboard_left"), + E(5, "checkl", "checkboard_left"), // unsupported by vf_stereo3d E(6, "irr", "row_interleaved_right"), E(7, "irl", "row_interleaved_left"), E(8, "icr", "column_interleaved_right"),// unsupported by vf_stereo3d diff --git a/video/csputils.h b/video/csputils.h index 1a559ebfd2..a99fe5b280 100644 --- a/video/csputils.h +++ b/video/csputils.h @@ -79,9 +79,11 @@ enum mp_render_intent { MP_INTENT_ABSOLUTE_COLORIMETRIC = 3 }; +// The numeric values (except -1) match the Matroska StereoMode element value. enum mp_stereo3d_mode { MP_STEREO3D_INVALID = -1, MP_STEREO3D_MONO = 0, + /* no explicit enum entries for most valid values */ MP_STEREO3D_COUNT = 13, // 12 is last valid mode }; -- cgit v1.2.3