From 863a05025825bca41afe733db983d3eae5702d35 Mon Sep 17 00:00:00 2001
From: wm4 <wm4@nowhere>
Date: Fri, 21 Nov 2014 10:08:20 +0100
Subject: parse_configfile: check quote termination properly

This is some terrible code; I blame MPlayer legacy.

Found by Coverity.
---
 options/parse_configfile.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/options/parse_configfile.c b/options/parse_configfile.c
index 44ac649592..48a2c25318 100644
--- a/options/parse_configfile.c
+++ b/options/parse_configfile.c
@@ -156,6 +156,13 @@ int m_config_parse_config_file(m_config_t *config, const char *conffile,
                 c = line[line_pos];
                 ++line_pos;
                 for (param_pos = 0; line[line_pos] != c; /* NOTHING */) {
+                    if (!line[line_pos]) {
+                        PRINT_LINENUM;
+                        MP_ERR(config, "unterminated quotes\n");
+                        ret = -1;
+                        errors++;
+                        goto nextline;
+                    }
                     param[param_pos++] = line[line_pos++];
                     if (param_pos >= MAX_PARAM_LEN) {
                         PRINT_LINENUM;
-- 
cgit v1.2.3