From 5c313f1f5965eb8f00c3d242d9e27e9612dc949b Mon Sep 17 00:00:00 2001 From: sfan5 Date: Thu, 29 Aug 2019 21:52:50 +0200 Subject: vo: add warning message to vo_vaapi and vo_vdpau These are a common source of bug reports, due to misconceptions that they are required to make use of hardware decoding. --- video/out/vo_vaapi.c | 5 +++++ video/out/vo_vdpau.c | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/video/out/vo_vaapi.c b/video/out/vo_vaapi.c index c8ffffcb1e..c94fbf56f7 100644 --- a/video/out/vo_vaapi.c +++ b/video/out/vo_vaapi.c @@ -866,6 +866,11 @@ static int preinit(struct vo *vo) vo->hwdec_devs = hwdec_devices_create(); hwdec_devices_add(vo->hwdec_devs, &p->mpvaapi->hwctx); + MP_WARN(vo, "Warning: this compatibility VO is low quality and may " + "have issues with OSD, scaling, screenshots and more.\n" + "vo=gpu is the preferred choice in any case and " + "includes VA-API support via hwdec=vaapi or vaapi-copy.\n"); + return 0; fail: diff --git a/video/out/vo_vdpau.c b/video/out/vo_vdpau.c index 9871355330..6bbd4f9e92 100644 --- a/video/out/vo_vdpau.c +++ b/video/out/vo_vdpau.c @@ -1046,6 +1046,11 @@ static int preinit(struct vo *vo) vc->vdp->bitmap_surface_query_capabilities(vc->vdp_device, VDP_RGBA_FORMAT_A8, &vc->supports_a8, &(uint32_t){0}, &(uint32_t){0}); + MP_WARN(vo, "Warning: this compatibility VO is low quality and may " + "have issues with OSD, scaling, screenshots and more.\n" + "vo=gpu is the preferred choice in any case and " + "includes VDPAU support via hwdec=vdpau or vdpau-copy.\n"); + return 0; } -- cgit v1.2.3