From 547976633f41c245b9accd6906166bb450e13557 Mon Sep 17 00:00:00 2001 From: wm4 Date: Thu, 16 Apr 2015 22:06:47 +0200 Subject: command: let screenshot_to_file command overwrite files The old behavior does not make too much sense after all. If you don't want to file to be overwritten, the user can check this manually. This is a change in behavior - let's hope nobody actually relied on it. --- DOCS/man/input.rst | 3 +-- player/screenshot.c | 5 ----- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/DOCS/man/input.rst b/DOCS/man/input.rst index a3bad3706b..7209f508d9 100644 --- a/DOCS/man/input.rst +++ b/DOCS/man/input.rst @@ -187,8 +187,7 @@ List of Input Commands The second argument is like the first argument to ``screenshot``. - This command tries to never overwrite files. If the file already exists, - it fails. + If the file already exists, it's overwritten. Like all input command parameters, the filename is subject to property expansion as described in `Property Expansion`_. diff --git a/player/screenshot.c b/player/screenshot.c index ec01adffaa..3a1a41a4ca 100644 --- a/player/screenshot.c +++ b/player/screenshot.c @@ -370,11 +370,6 @@ void screenshot_to_file(struct MPContext *mpctx, const char *filename, int mode, bool old_osd = ctx->osd; ctx->osd = osd; - if (mp_path_exists(filename)) { - screenshot_msg(ctx, SMSG_ERR, "Screenshot: file '%s' already exists.", - filename); - goto end; - } char *ext = mp_splitext(filename, NULL); if (ext) opts.format = ext; -- cgit v1.2.3