From 3b2cc79d2f42eefebf4390ccf722e1bb02d6f734 Mon Sep 17 00:00:00 2001 From: robin007bond Date: Mon, 13 Apr 2015 14:51:03 +0200 Subject: DOCS/contribute.md: Add guideline for pull requests This commit is to prevent changes being merged into upstream, without being known if it is tested or not. Signed-off-by: wm4 --- DOCS/contribute.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/DOCS/contribute.md b/DOCS/contribute.md index 224c52494c..11b5e33d50 100644 --- a/DOCS/contribute.md +++ b/DOCS/contribute.md @@ -14,6 +14,9 @@ Sending patches ``git format-patch``. diffs posted as pastebins (especially if the http link returns HTML) just cause extra work for everyone, because they lack commit message and authorship information. +- When creating pull requests, be sure to test your changes. If you didn't, please + say so in the pull request message. + - Write informative commit messages. Use present tense to describe the situation with the patch applied, and past tense for the situation before the change. -- cgit v1.2.3