From 1cd11c43ee855eecc49fe43853450854ffc8b900 Mon Sep 17 00:00:00 2001 From: wm4 Date: Thu, 29 Jan 2015 20:28:39 +0100 Subject: command: change sub-visibility OSD message Now it shows one of: - "Subtitles hidden" (sub-visibility=no) - "Subtitles visible" (sub-visibility=yes, sub!=no) - "Subtitles visible (but no subtitles selected)" (otherwise) It should be a bit more self-explanatory than before. On the other hand, I have no clue about UI issues. This also gets close to what's reasonably possible with the OSD expansion string syntax, which is why it looks so awful. --- player/command.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/player/command.c b/player/command.c index 8779ea8c0a..ab7e973b2e 100644 --- a/player/command.c +++ b/player/command.c @@ -3636,7 +3636,8 @@ static const struct property_osd_display { { "secondary-sid", "Secondary subtitles" }, { "sub-pos", "Sub position" }, { "sub-delay", "Sub delay" }, - { "sub-visibility", "Subtitles" }, + { "sub-visibility", .msg = "Subtitles ${!sub-visibility==yes:hidden}" + "${?sub-visibility==yes:visible${?sub==no: (but no subtitles selected)}}" }, { "sub-forced-only", "Forced sub only" }, { "sub-scale", "Sub Scale"}, { "ass-vsfilter-aspect-compat", "Subtitle VSFilter aspect compat"}, -- cgit v1.2.3