From 08432fcbd11cfb958e29307ea277f67c13f56dde Mon Sep 17 00:00:00 2001 From: wm4 Date: Sun, 18 Sep 2016 17:55:27 +0200 Subject: command: fix "cycle"/"add" not working on most properties Oops, this is kind of important, isn't it? Stopped working for properties which don't implement M_PROPERTY_GET_CONSTRICTED_TYPE directly, as do_action() goes to the property directly, while m_property_do() does a fallback. --- options/m_property.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/options/m_property.c b/options/m_property.c index ba8d37b2e6..9dad34fd1b 100644 --- a/options/m_property.c +++ b/options/m_property.c @@ -115,7 +115,8 @@ int m_property_do(struct mp_log *log, const struct m_property *prop_list, M_PROPERTY_NOT_IMPLEMENTED) return r; // Fallback to m_option - r = do_action(prop_list, name, M_PROPERTY_GET_CONSTRICTED_TYPE, &opt, ctx); + r = m_property_do(log, prop_list, name, M_PROPERTY_GET_CONSTRICTED_TYPE, + &opt, ctx); if (r <= 0) return r; assert(opt.type); -- cgit v1.2.3