From 046ad8c5aef8e0b72b823bb4ac5f875db33dd1dd Mon Sep 17 00:00:00 2001 From: wm4 Date: Wed, 8 Oct 2014 12:49:04 +0200 Subject: msg: set an explicit overflow message So client API users don't have to worry about this specifically. Also document the overflow case. (Not sure if we really need to do this; maybe it'd be better not to, since this just adds more noise to the docs.) --- common/msg.c | 2 +- libmpv/client.h | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/common/msg.c b/common/msg.c index 866cae5c9d..21fae360be 100644 --- a/common/msg.c +++ b/common/msg.c @@ -321,7 +321,7 @@ static void write_msg_to_buffers(struct mp_log *log, int lev, char *text) *entry = (struct mp_log_buffer_entry) { .prefix = "overflow", .level = MSGL_FATAL, - .text = "", + .text = "log message buffer overflow\n", }; } mp_ring_write(buffer->ring, (unsigned char *)&entry, sizeof(entry)); diff --git a/libmpv/client.h b/libmpv/client.h index fe7efa66f8..c4df6a3fbf 100644 --- a/libmpv/client.h +++ b/libmpv/client.h @@ -1032,7 +1032,10 @@ typedef struct mpv_event_property { typedef struct mpv_event_log_message { /** - * The module prefix, identifies the sender of the message. + * The module prefix, identifies the sender of the message. As a special + * case, if the message buffer overflows, this will be set to the string + * "overflow" (which doesn't appear as prefix otherwise), and the text + * field will contain an informative message. */ const char *prefix; /** -- cgit v1.2.3