summaryrefslogtreecommitdiffstats
path: root/DOCS/tech/patches.txt
diff options
context:
space:
mode:
Diffstat (limited to 'DOCS/tech/patches.txt')
-rw-r--r--DOCS/tech/patches.txt11
1 files changed, 6 insertions, 5 deletions
diff --git a/DOCS/tech/patches.txt b/DOCS/tech/patches.txt
index 3093984309..cdc931410e 100644
--- a/DOCS/tech/patches.txt
+++ b/DOCS/tech/patches.txt
@@ -18,10 +18,11 @@ that your patch will be included.
2. Make unified diffs ('diff -Naur' or 'cvs diff -u'). Unified diffs can be
applied easily with 'patch'. This is much harder with other diff types.
+ Besides, unified diffs are more readable and thus easier to review.
3. Create the diff from the root of the MPlayer source tree, this makes the
- diff easier to apply as it saves the step of changing to the correct
- directory.
+ diff easier to apply as it saves the step of searching for and changing
+ to the correct directory.
4. Test the functionality of your patch. We'll *refuse* it if it breaks
something, even if it extends other features!
@@ -107,9 +108,9 @@ that your patch will be included.
and translators will pick up changes more easily if they see a new message
that has to be translated.
-15. If you send a modified or updated version of you patch, always resend
- the complete patch. It is very time consuming and error prone to piece
- patches together that are distributed over several mails.
+15. If you send a modified or updated version of your patch, resend the
+ complete patch. It is very time-consuming and error-prone to piece
+ together patches that are distributed over several mails.
Please always resend patches as replies to the original mail to keep
the thread with the discussion together.