path: root/
diff options
authorJames Ross-Gowan <>2020-07-19 23:50:25 +1000
committerwm4 <wm4@nowhere>2020-07-20 21:02:17 +0200
commit83fec9bafb13d4b506c41c0a4394ce6869f5b4f3 (patch)
treea3daf8a00572a49f2043c46bff75baece46e7c57 /
parent4476911d45652d99df1e1a66b5aea48d4ef9a070 (diff)
subprocess-win: update to mp_subprocess2
This fixes the "run" and "subprocess" commands on Windows, including youtube-dl support. Unix-like FD inheritance is emulated on Windows by using an undocumented data structure[1] that gets passed to the newly created process in STARTUPINFO.lpReserved2. It consists of two sparse arrays listing the HANDLE and internal CRT flags corresponding to each FD. This structure is used and understood primarily by MSVCRT, but there are other runtimes and frameworks that can write it, like libuv. The code for creating asynchronous "anonymous" pipes in Windows has been enhanced and moved into windows_utils.c. This is mainly an artifact of an unfinished future change to support anonymous IPC clients in Windows. Right now, it's still only used in subprocess-win.c [1]:
Diffstat (limited to '')
1 files changed, 1 insertions, 1 deletions
diff --git a/ b/
index 746cb16261..7cf5d5a784 100644
--- a/
+++ b/
@@ -208,7 +208,7 @@ def build(ctx):
subprocess_c = ctx.pick_first_matching_dep([
( "osdep/subprocess-posix.c", "posix" ),
- # broken ( "osdep/subprocess-win.c", "win32-desktop" ),
+ ( "osdep/subprocess-win.c", "win32-desktop" ),
( "osdep/subprocess-dummy.c" ),